Remove usage of PHP alias in the Python client #663
Conversation
|
Since the Epidata cient API is changing, we'll need to update the version number required in |
|
@capnrefsmmat good point! I bumped the version once and will change it again if the release ends up being e.g. 4.1.3. |
|
Did you get a chance to run tests for this with the updated client from cmu-delphi/delphi-epidata#1288 ? I think you might need to update the covidcast/Python-packages/covidcast-py/tests/test_covidcast.py Lines 261 to 263 in 474dc20 |
|
can we update the changelog, and then follow this set of instructions to update the version number for the package and rebuild docs and other artifacts? then we will be prepped to upload to PyPI when everything else is done. |
|
@dshemetov makes a good point in cmu-delphi/delphi-epidata#1288 (comment) ... we should probably put documentation and show warning messages for deprecating |
| - Remove usage of PHP alias in the Python client. | ||
| - Use Python package-specific "user agent" string. | ||
| - Mark :py:func:`_async_fetch_epidata` as deprecated. |
There was a problem hiding this comment.
| - Remove usage of PHP alias in the Python client. | |
| - Use Python package-specific "user agent" string. | |
| - Mark :py:func:`_async_fetch_epidata` as deprecated. | |
| - New feature: Web requests now identify themselves with a `covidcast`-specific "user agent" string. | |
| - Update: Now uses newer version of the `delphi-epidata` libarary. | |
| - Bug fix: Removed usage of PHP alias endpoint for compatibility with new `delphi-epidata` version. | |
| - Deprecated function: Private method :py:func:`_async_fetch_epidata` has been deprecated. |
|
@rzats this is failing at the linter now, i guess you didnt go through that part of the tests? |
|
linting/pydocstyle is happy now, but now python tests are failing... @rzats can you take a look? |
|
@melange396 latest round of tests is passing! |
Secondary PR to cmu-delphi/delphi-epidata#1288 that should be merged & deployed alongside it - fixed the delphi-epidata version to the newest client.